virt-manager: Fix 'ImportError: No module named libvirt' and add Spice support#1475
Closed
wizeman wants to merge 2 commits intoNixOS:masterfrom
Closed
virt-manager: Fix 'ImportError: No module named libvirt' and add Spice support#1475wizeman wants to merge 2 commits intoNixOS:masterfrom
wizeman wants to merge 2 commits intoNixOS:masterfrom
Conversation
Member
There was a problem hiding this comment.
why don't you use buildPythonPackage here?
Member
Author
There was a problem hiding this comment.
I tried, but the derivation ended up with no files in it:
# find /nix/store/b010qffb8hk103q172qzw6k9gdxzblyb-python2.7-libvirt-python-1.2.0
/nix/store/b010qffb8hk103q172qzw6k9gdxzblyb-python2.7-libvirt-python-1.2.0
/nix/store/b010qffb8hk103q172qzw6k9gdxzblyb-python2.7-libvirt-python-1.2.0/lib
/nix/store/b010qffb8hk103q172qzw6k9gdxzblyb-python2.7-libvirt-python-1.2.0/lib/python2.7
/nix/store/b010qffb8hk103q172qzw6k9gdxzblyb-python2.7-libvirt-python-1.2.0/lib/python2.7/site-packages
/nix/store/b010qffb8hk103q172qzw6k9gdxzblyb-python2.7-libvirt-python-1.2.0/nix-support
/nix/store/b010qffb8hk103q172qzw6k9gdxzblyb-python2.7-libvirt-python-1.2.0/nix-support/propagated-native-build-inputs
Member
|
Aha, that's likely to get fixed with #1467 |
Member
Author
|
Rebased and added a missing Spice widget for virt-manager, it allows graphical interaction with VMs much faster than VNC. |
Member
There was a problem hiding this comment.
spice_gtk is not present in nixpkgs? you forgot to push this part? is it in some other pull request i'm not seeing?
Member
Author
There was a problem hiding this comment.
@garbas You're right, sorry. I have added and pushed the missing commit now.
Thanks!
The problem was that libvirt 1.2.0 no longer includes the python bindings; it is a separate package now.
Member
|
great. merged manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error was due to libvirt 1.2.0 no longer including the python bindings; it is
a separate package now.
Also added a missing Spice widget for virt-manager, it allows graphical interaction with VMs much faster than VNC.